| ... | @@ -312,4 +312,45 @@ Master A-<name> B-<name> C-<name> D-<name> |
... | @@ -312,4 +312,45 @@ Master A-<name> B-<name> C-<name> D-<name> |
|
|
- All branches will go through the CI/CD pipe, and, only if they pass build, test and deploy pipes will they be merged.
|
|
- All branches will go through the CI/CD pipe, and, only if they pass build, test and deploy pipes will they be merged.
|
|
|
- The above Example should be documented in a readme in the project (I need to talk with Judi first to see what she thinks)
|
|
- The above Example should be documented in a readme in the project (I need to talk with Judi first to see what she thinks)
|
|
|
|
|
|
|
|
4:18 PM - Finished Work |
|
4:18 PM - Finished Work
|
|
\ No newline at end of file |
|
|
|
|
|
# Sept 21, 2021
|
|
|
|
|
|
|
|
9:54 AM - Started Work
|
|
|
|
|
|
|
|
- Spent two hours trying to fix a bug, turns out I wrote "fata" instead of "data"... sigh, waste of time over such a small mistake... rip
|
|
|
|
|
|
|
|
## Features
|
|
|
|
|
|
|
|
### Repo Incorperation (Student Side)
|
|
|
|
|
|
|
|
- Finished repo incorperation feature for students in IFS.
|
|
|
|
- Needs heavy refactoring as majority of functionality was copied from the instructor's side
|
|
|
|
- Need to make tests for the added functionality
|
|
|
|
|
|
|
|
## Issues
|
|
|
|
|
|
|
|
### Refactor Components
|
|
|
|
|
|
|
|
- Some components are shared between instructors and students.
|
|
|
|
- Rather than having individual components, make one `.js` file for the component and just modify the functions or variable you toss in as probs in the `.js` file that contains the component
|
|
|
|
|
|
|
|
### Refactor Project Structure
|
|
|
|
|
|
|
|
- Sorry to be blunt, but the project structure is horrible.
|
|
|
|
- Will be moving some files around and changing folder names shortly
|
|
|
|
|
|
|
|
### Refactor Functions
|
|
|
|
|
|
|
|
- Some functions are being tossed into a component as a prop when it should just be incorperated into the components `.js` file
|
|
|
|
- This gets confusing, as functions are spread over way to many files.
|
|
|
|
- personally, to me it's just to much of a hastle having to change files to see what a function does
|
|
|
|
- Functions should be in the highest lever <b>where it is used</b>
|
|
|
|
- By thi I mean, a if a parent and a child container both use the function, put it in the parent.
|
|
|
|
- If only the child container uses the function, put it in the child, not in the parent like this project has in some areas of the code.
|
|
|
|
|
|
|
|
|
|
|
|
## Branch Naming Convention
|
|
|
|
|
|
|
|
- Finished developing the naming convention we will use
|
|
|
|
- Updated wiki to add this. |
