Update Tim's Journal authored by Timothy Catana's avatar Timothy Catana
......@@ -796,3 +796,42 @@ Master A-<name> B-<name> C-<name> D-<name>
- Planned how to refactor async/await functions
- will finish epic &8 tomorrow
- Today's thanksgiving so I'm quitting early to spend some time with friends and family
# October 12
# Overview
- Modified async/await functions to conform with code review
- The suggestion in the code review was actually really good
- The code is much more readable and cut down on quite a few lines of code
- Gitlab was down for a bit so I lost a bit of time
- Created a merge request to merge epic 8 branch into master
# Closed Issues
### #274
- The async functions with await/axios calls now look much cleaner
# Issues
### #279
- The instructor and the course page should be identical in code.
- The `StudentPage` code is <b>much</b> better and cleaner than the `CoursePage` (in the instrcutor side) code
- Also, `StudentPage` has more functionality
### #280
- IDK why the instructor coursepage randomly assigns id to name in the getproject async functions
- Apparently they did it to keep the data uniform
- The student side doesn't do this and if we do not need it when why set it anyway?
- IDK if we need the id, but if we do we can set it a different way
### #281
- Need better error handling
- When something isn't fetched properly, usually we just set a the variable we are using to the error's response data
- This just crashes the site
- Maybe we can have cleaner error handling and just prevent the program from continuing any calculation if a required variable isn't fetched properly
- Also, we can simply just show a alert or a quick message saying "unable to get ______" for example
\ No newline at end of file